Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize the search process for creators #818

Merged
merged 5 commits into from
Jul 17, 2024

Conversation

k163377
Copy link
Contributor

@k163377 k163377 commented Jul 14, 2024

Optimize the search process for creators.
This improves first-time processing performance and memory usage since it is no longer necessary to check for the existence of other JsonCreator on the class.
It also solves the problem of findCreatorAnnotation results by AnnotationIntrospector registered by the user being ignored depending on the order in which modules are registered.

Fixes #805.

@k163377
Copy link
Contributor Author

k163377 commented Jul 14, 2024

The following issues must be resolved before merging
FasterXML/jackson-databind#4620

@k163377 k163377 changed the title Feat/creator Optimize the search process for creators Jul 14, 2024
@cowtowncoder
Copy link
Member

Databind#4620 fixed, will re-run tests.

@cowtowncoder
Copy link
Member

@k163377 Looks good, all tests now pass it looks like.

@k163377 k163377 marked this pull request as ready for review July 17, 2024 12:42
@k163377 k163377 merged commit 016a441 into FasterXML:2.18 Jul 17, 2024
15 checks passed
@k163377 k163377 deleted the feat/creator branch July 17, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants