Improve large numbers initialization in test data #2324

noisersup · 2023-03-29T15:14:01Z

Description

Please also take a look at #2321 which should be done after merging this one.

Readiness checklist

I added/updated unit tests.
I added/updated integration/compatibility tests.
I added/updated comments and checked rendering.
I made spot refactorings.
I updated user documentation.
I ran task all, and it passed.
I ensured that PR title is good enough for the changelog.
(for maintainers only) I set Reviewers (@FerretDB/core), Assignee, Labels, Project and project's Sprint fields.
I marked all done items in this checklist.

chilagrow

The shareddata is changed, some values seem missing. Perhaps there is a reason?

integration/shareddata/scalars.go

internal/util/must/must.go

rumyantseva

Great job clarifying those things!

I left a few comments about the consistency of the cases.

As far as I understand, for negative cases (<0), we should have minus two, minus one, the value itself, plus one. For positive cases (>0) we should have minus one, the value itself, plus one, plus two. But in some cases, it's not exactly like this.

integration/shareddata/scalars.go

Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>

Co-authored-by: Elena Grahovac <elena@grahovac.me>

codecov · 2023-03-30T11:11:06Z

Codecov Report

Merging #2324 (b409055) into main (cc6c473) will increase coverage by 0.02%.
The diff coverage is 88.23%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2324      +/-   ##
==========================================
+ Coverage   27.94%   27.96%   +0.02%     
==========================================
  Files         387      387              
  Lines       18496    18513      +17     
==========================================
+ Hits         5168     5178      +10     
- Misses      12775    12780       +5     
- Partials      553      555       +2

Impacted Files	Coverage Δ
internal/types/types.go	`70.17% <ø> (ø)`
internal/util/must/must.go	`40.00% <33.33%> (-2.86%)`	⬇️
integration/shareddata/scalars.go	`100.00% <100.00%> (ø)`

... and 2 files with indirect coverage changes

Flag	Coverage Δ
integration	`4.91% <88.23%> (+0.07%)`	⬆️
mongodb	`4.91% <88.23%> (+0.07%)`	⬆️
unit	`26.62% <0.00%> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

w84thesun

👍

integration/shareddata/scalars.go

@chilagrow

v1.0.0 https://github.com/FerretDB/FerretDB/releases/tag/v1.0.0 2023-04-03 We are delighted to announce the release of FerretDB 1.0 GA! * Support `$sum` accumulator of `$group` aggregation by @chilagrow in FerretDB#2292 * Implement `createIndexes` command by @rumyantseva in FerretDB#2244 * Add basic `getMore` command by @AlekSi in FerretDB#2309 * Implement `dropIndexes` command by @chilagrow in FerretDB#2313 * Implement `$limit` aggregation pipeline stage by @noisersup in FerretDB#2270 * Add partial support for `collStats`, `dbStats` and `dataSize` by @AlekSi in FerretDB#2322 * Implement `$skip` aggregation pipeline stage by @w84thesun in FerretDB#2310 * Implement `$unwind` aggregation pipeline stage by @noisersup in FerretDB#2294 * Support `count` and `storageStats` fields in `$collStats` aggregation pipeline stage by @rumyantseva in FerretDB#2338 * Fix dot notation negative index errors by @w84thesun in FerretDB#2246 * Apply `skip` before `limit` by @AlekSi in FerretDB#2351 * Update supported command for `$sum` aggregation operator by @chilagrow in FerretDB#2318 * Add supported shells and GUIs images by @AlekSi in FerretDB#2323 * Publish FerretDB v0.9.4 blog post by @Fashander in FerretDB#2268 * Use dashes instead of underscores or spaces by @AlekSi in FerretDB#2329 * Update documentation sidebar by @Fashander in FerretDB#2347 * Update FerretDB descriptions by @AlekSi in FerretDB#2281 * Improve flags documentation by @AlekSi in FerretDB#2331 * Describe supported fields for `$collStats` aggregation stage by @rumyantseva in FerretDB#2352 * Use iterators for `sort`, `limit`, `skip`, and `projection` by @AlekSi in FerretDB#2254 * Bump dependencies by @AlekSi in FerretDB#2307 * Improve resource tracking by @AlekSi in FerretDB#2319 * Add tests for `find`'s and `count`'s `skip` argument by @w84thesun in FerretDB#2325 * Close iterator properly by @AlekSi in FerretDB#2333 * Improve large numbers initialization in test data by @noisersup in FerretDB#2324 * Ignore `unique` index option for now by @AlekSi in FerretDB#2350 All closed issues and pull requests: https://github.com/FerretDB/FerretDB/milestone/39?closed=1 All commits: FerretDB/FerretDB@v0.9.4...v1.0.0

@chilagrow

v1.0.0 https://github.com/FerretDB/FerretDB/releases/tag/v1.0.0 2023-04-03 We are delighted to announce the release of FerretDB 1.0 GA! * Support `$sum` accumulator of `$group` aggregation by @chilagrow in FerretDB#2292 * Implement `createIndexes` command by @rumyantseva in FerretDB#2244 * Add basic `getMore` command by @AlekSi in FerretDB#2309 * Implement `dropIndexes` command by @chilagrow in FerretDB#2313 * Implement `$limit` aggregation pipeline stage by @noisersup in FerretDB#2270 * Add partial support for `collStats`, `dbStats` and `dataSize` by @AlekSi in FerretDB#2322 * Implement `$skip` aggregation pipeline stage by @w84thesun in FerretDB#2310 * Implement `$unwind` aggregation pipeline stage by @noisersup in FerretDB#2294 * Support `count` and `storageStats` fields in `$collStats` aggregation pipeline stage by @rumyantseva in FerretDB#2338 * Fix dot notation negative index errors by @w84thesun in FerretDB#2246 * Apply `skip` before `limit` by @AlekSi in FerretDB#2351 * Update supported command for `$sum` aggregation operator by @chilagrow in FerretDB#2318 * Add supported shells and GUIs images by @AlekSi in FerretDB#2323 * Publish FerretDB v0.9.4 blog post by @Fashander in FerretDB#2268 * Use dashes instead of underscores or spaces by @AlekSi in FerretDB#2329 * Update documentation sidebar by @Fashander in FerretDB#2347 * Update FerretDB descriptions by @AlekSi in FerretDB#2281 * Improve flags documentation by @AlekSi in FerretDB#2331 * Describe supported fields for `$collStats` aggregation stage by @rumyantseva in FerretDB#2352 * Use iterators for `sort`, `limit`, `skip`, and `projection` by @AlekSi in FerretDB#2254 * Bump dependencies by @AlekSi in FerretDB#2307 * Improve resource tracking by @AlekSi in FerretDB#2319 * Add tests for `find`'s and `count`'s `skip` argument by @w84thesun in FerretDB#2325 * Close iterator properly by @AlekSi in FerretDB#2333 * Improve large numbers initialization in test data by @noisersup in FerretDB#2324 * Ignore `unique` index option for now by @AlekSi in FerretDB#2350 All closed issues and pull requests: https://github.com/FerretDB/FerretDB/milestone/39?closed=1 All commits: FerretDB/FerretDB@v0.9.4...v1.0.0

noisersup added 5 commits March 29, 2023 15:24

wip

5a592f0

Merge branch 'main' into shareddata-refactor

02efbf0

wip

f4bd43f

Merge branch 'main' into shareddata-refactor

b446844

wip

cc8fb31

noisersup self-assigned this Mar 29, 2023

noisersup added the code/chore Code maintenance improvements label Mar 29, 2023

noisersup marked this pull request as ready for review March 29, 2023 15:53

noisersup requested a review from a team as a code owner March 29, 2023 15:53

noisersup requested review from AlekSi, w84thesun, rumyantseva, chilagrow and a team March 29, 2023 15:53

noisersup enabled auto-merge (squash) March 29, 2023 15:56

chilagrow reviewed Mar 30, 2023

View reviewed changes

integration/shareddata/scalars.go Show resolved Hide resolved

integration/shareddata/scalars.go Show resolved Hide resolved

integration/shareddata/scalars.go Show resolved Hide resolved

AlekSi reviewed Mar 30, 2023

View reviewed changes

internal/util/must/must.go Outdated Show resolved Hide resolved

rumyantseva reviewed Mar 30, 2023

View reviewed changes

integration/shareddata/scalars.go Outdated Show resolved Hide resolved

integration/shareddata/scalars.go Outdated Show resolved Hide resolved

integration/shareddata/scalars.go Show resolved Hide resolved

integration/shareddata/scalars.go Show resolved Hide resolved

noisersup and others added 3 commits March 30, 2023 09:19

"can't" be false

e691089

Co-authored-by: Alexey Palazhchenko <alexey.palazhchenko@gmail.com>

Update integration/shareddata/scalars.go

7d828cf

Co-authored-by: Elena Grahovac <elena@grahovac.me>

wip

8f6f408

noisersup requested review from AlekSi, rumyantseva and chilagrow March 30, 2023 10:41

Merge branch 'main' into shareddata-refactor

eaba223

w84thesun previously approved these changes Mar 30, 2023

View reviewed changes

chilagrow previously approved these changes Mar 31, 2023

View reviewed changes

integration/shareddata/scalars.go Show resolved Hide resolved

integration/shareddata/scalars.go Show resolved Hide resolved

integration/shareddata/scalars.go Show resolved Hide resolved

mergify bot and others added 2 commits March 31, 2023 08:56

Merge branch 'main' into shareddata-refactor

2f4e303

wip

3332a4f

noisersup dismissed stale reviews from chilagrow and w84thesun via 3332a4f March 31, 2023 09:16

noisersup added 2 commits March 31, 2023 16:32

fix

4b2dd43

Merge branch 'main' into shareddata-refactor

e5003d6

noisersup requested review from w84thesun and chilagrow March 31, 2023 14:33

rumyantseva approved these changes Mar 31, 2023

View reviewed changes

w84thesun approved these changes Mar 31, 2023

View reviewed changes

Merge branch 'main' into shareddata-refactor

b409055

noisersup merged commit f0d6f83 into FerretDB:main Mar 31, 2023

noisersup deleted the shareddata-refactor branch March 31, 2023 15:41

AlekSi added this to the v1.0.0 GA milestone Apr 10, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve large numbers initialization in test data #2324

Improve large numbers initialization in test data #2324

noisersup commented Mar 29, 2023 •

edited

Loading

chilagrow left a comment

rumyantseva left a comment •

edited

Loading

codecov bot commented Mar 30, 2023 •

edited

Loading

w84thesun left a comment

Improve large numbers initialization in test data #2324

Improve large numbers initialization in test data #2324

Conversation

noisersup commented Mar 29, 2023 • edited Loading

Description

Readiness checklist

chilagrow left a comment

Choose a reason for hiding this comment

rumyantseva left a comment • edited Loading

Choose a reason for hiding this comment

codecov bot commented Mar 30, 2023 • edited Loading

Codecov Report

w84thesun left a comment

Choose a reason for hiding this comment

noisersup commented Mar 29, 2023 •

edited

Loading

rumyantseva left a comment •

edited

Loading

codecov bot commented Mar 30, 2023 •

edited

Loading