Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix count's query parameter #2622

Merged
merged 3 commits into from
May 12, 2023
Merged

Conversation

w84thesun
Copy link
Contributor

@w84thesun w84thesun commented May 12, 2023

Description

Readiness checklist

  • I added/updated unit tests.
  • I added/updated integration/compatibility tests.
  • I added/updated comments and checked rendering.
  • I made spot refactorings.
  • I updated user documentation.
  • I ran task all, and it passed.
  • I ensured that PR title is good enough for the changelog.
  • (for maintainers only) I set Reviewers (@FerretDB/core), Labels, Project and project's Sprint fields.
  • I marked all done items in this checklist.

@w84thesun w84thesun added the code/bug Some user-visible feature works incorrectly label May 12, 2023
@w84thesun w84thesun self-assigned this May 12, 2023
@w84thesun w84thesun changed the title Fix count query parameter Fix count's query parameter May 12, 2023
@w84thesun w84thesun requested review from a team, rumyantseva, chilagrow and noisersup May 12, 2023 10:03
@w84thesun w84thesun marked this pull request as ready for review May 12, 2023 10:03
@w84thesun w84thesun requested a review from a team as a code owner May 12, 2023 10:03
@w84thesun w84thesun enabled auto-merge (squash) May 12, 2023 10:04
@AlekSi AlekSi added this to the Next milestone May 12, 2023
@AlekSi AlekSi added code/chore Code maintenance improvements and removed code/bug Some user-visible feature works incorrectly labels May 12, 2023
@AlekSi
Copy link
Member

AlekSi commented May 12, 2023

It is not a bug because the breaking change wasn't released yet

@codecov
Copy link

codecov bot commented May 12, 2023

Codecov Report

Merging #2622 (bbe4e69) into main (11a979f) will decrease coverage by 38.14%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2622       +/-   ##
===========================================
- Coverage   65.98%   27.84%   -38.14%     
===========================================
  Files         419      419               
  Lines       20553    20553               
===========================================
- Hits        13561     5724     -7837     
- Misses       6039    14242     +8203     
+ Partials      953      587      -366     
Impacted Files Coverage Δ
internal/handlers/common/count.go 0.00% <ø> (-100.00%) ⬇️

... and 137 files with indirect coverage changes

Flag Coverage Δ
integration 5.39% <ø> (-53.48%) ⬇️
mongodb 5.39% <ø> (ø)
pg ?
unit 26.29% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@w84thesun w84thesun merged commit f98dc95 into FerretDB:main May 12, 2023
@w84thesun w84thesun deleted the fix-count-parameters branch May 12, 2023 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code/chore Code maintenance improvements
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants