-
Notifications
You must be signed in to change notification settings - Fork 392
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ignore Stable API fields #4067
Ignore Stable API fields #4067
Conversation
fa95660
to
473c48c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should do FerretDB/dance#769 first
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4067 +/- ##
==========================================
- Coverage 75.71% 73.58% -2.13%
==========================================
Files 304 304
Lines 21620 21620
==========================================
- Hits 16370 15910 -460
- Misses 4112 4592 +480
+ Partials 1138 1118 -20
... and 37 files with indirect coverage changes
Flags with carried forward coverage won't be shown. Click here to find out more. |
@Evengard this pull request has merge conflicts. |
# Conflicts: # internal/handler/common/insert.go
Thank you! |
apiVersion
field from StableAPI
apiVersion
field from StableAPI
Description
When using the StableAPI, clients sends along an apiVersion and some other fields, which aren't recognized by FerretDB. Otherwise the command is fine. Just ignoring them seems to work fine. Tested with MongoDB.Driver (C#) 2.23.1
Mimicked the LSID ignore code, except defined the actual
string
andbool
types for them.Closes #3121.
Readiness checklist
task all
, and it passed.@FerretDB/core
), Milestone (Next
), Labels, Project and project's Sprint fields.