Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove aria-hidden="true" from mobile navigation #954

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

notlee
Copy link
Contributor

@notlee notlee commented Oct 12, 2022

aria-hidden="true" is always applied on the mobile navigation. This means assistive tech users can't navigate to markets data on mobile.
It seems unnecessary as display: none is set on desktop.

Screenshot 2022-10-12 at 11 51 47
Screenshot 2022-10-12 at 11 51 18

@notlee notlee requested a review from a team as a code owner October 12, 2022 10:52
`aria-hidden="true"` is always applied on the mobile navigation.
This means assistive tech users can't navigate to markets data on mobile.
It seems unnecessary as `display: none` is set on desktop.
Copy link
Contributor

@jkerr321 jkerr321 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find, thanks Lee!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants