Even more backwards compatible (well sort of) #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joelcarr
approved these changes
Apr 10, 2024
Comment on lines
+45
to
+51
| return invalid([ | ||
| `plugin ${s.plugin(id)} has a v${s.code((plugin.rcFile.version ?? 1).toString())} ${s.code( | ||
| '.toolkitrc.yml' | ||
| )}, but this version of Tool Kit can only load v${s.code( | ||
| CURRENT_RC_FILE_VERSION.toString() | ||
| )}. please update this plugin.` | ||
| ]) |
There was a problem hiding this comment.
thought: Some assisting documentation to add as part of the major release to explain why this was done.
There was a problem hiding this comment.
yep. documentation (including a migration guide) will be coming later.
Base automatically changed from
slightly-more-backwards-compatible
to
CPP-1852-task-vs-plugin-options
April 10, 2024 10:51
apaleslimghost
force-pushed
the
even-more-backwards-compatible-well-sort-of
branch
from
8b7f3a4
to
f685467
Compare
apaleslimghost
force-pushed
the
even-more-backwards-compatible-well-sort-of
branch
from
f685467
to
a49c1aa
Compare
ivomurrell
pushed a commit
that referenced
this pull request
Sep 5, 2024
…atible-well-sort-of Even more backwards compatible (well sort of)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
versionfield to.toolkitrcthis should provide users with more actionable error messaging if they have outdated plugins, instead of trying to load an old toolkitrc expecting the current structure and which will probably throw some
cannot read property of undefinederror at some point