feat(wip): add a node-test plugin #688
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a node-test plugin using `node:test#run()`. There are quite a
few gotchas with this one:
* If we want to support Node.js 18 and 20 then we can't use glob
patterns (the `globPatterns` option) because it's only supported in
Node.js 22. I think glob patterns are important so I've replicated
wth the glob package.
* We don't support Node.js 18 less than v18.17.0, this is because
there wasn't a consistent JavaScript API for the built-in test
reporters before this version. This is captured in the engines. An
alternative would be to drop Node.js 18 support in this package as
we'll be doing this in April 2025 anyway.
* There is no way of configuring the built-in test runner via a config
file or similar. This means we need to expose more options than Jest
or Mocha in the Tool Kit config file.
rowanmanning
force-pushed
the
node-test-plugin
branch
from
37143a4
to
fd45dab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This is a draft because I'm looking for early feedback on my approach before writing a README or tests.
Description
This adds a node-test plugin using
node:test#run(). There are quite a few gotchas with this one:If we want to support Node.js 18 and 20 then we can't use glob patterns (the
globPatternsoption) because it's only supported in Node.js 22. I think glob patterns are important so I've replicated wth the glob package.We don't support Node.js 18 less than v18.17.0, this is because there wasn't a consistent JavaScript API for the built-in test reporters before this version. This is captured in the engines. An alternative would be to drop Node.js 18 support in this package as we'll be doing this in April 2025 anyway.
There is no way of configuring the built-in test runner via a config file or similar. This means we need to expose more options than Jest or Mocha in the Tool Kit config file.
Checklist:
feat(circleci): add support for nightly workflows,fix: set Heroku app name for staging apps too