Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up & document #113

Merged
merged 8 commits into from
Feb 25, 2019
Merged

Clean up & document #113

merged 8 commits into from
Feb 25, 2019

Conversation

apaleslimghost
Copy link
Member

@apaleslimghost apaleslimghost commented Feb 14, 2019 •
edited
Loading

  • remove memory check type that hasn't been usable for three years lol
  • refactor to use async/await
  • remove next. graphite check so it's usable outside of the program
  • actually document it

this has ended up being a backwards compatible change ☺️ i'll be doing more drastic changes for v4

@apaleslimghost apaleslimghost changed the title WIP Clean up Clean up & document Feb 14, 2019
@apaleslimghost apaleslimghost requested review from tom-parker, sjparkinson and a team and removed request for sjparkinson February 14, 2019 17:44
sjparkinson
sjparkinson approved these changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@sjparkinson sjparkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see anything using Memcheck 👍

@simonplend simonplend self-requested a review February 15, 2019 10:39
simonplend
simonplend approved these changes Feb 15, 2019
View reviewed changes
Copy link

@simonplend simonplend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request sparks joy 🎇

tom-parker
tom-parker approved these changes Feb 15, 2019
View reviewed changes
Copy link
Contributor

@tom-parker tom-parker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

adambraimbridge
adambraimbridge approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@adambraimbridge adambraimbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This health PR is fully sick. 👍

README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
src/checks/responseCompare.check.js Show resolved Hide resolved
@apaleslimghost
clarify office hours
97dacdb 
Co-Authored-By: quarterto <bren@153.io>
@apaleslimghost apaleslimghost merged commit ce34059 into master Feb 25, 2019
@apaleslimghost apaleslimghost deleted the clean-up branch February 25, 2019 11:08
@apaleslimghost apaleslimghost mentioned this pull request Feb 25, 2019
Closed
JSRedondo pushed a commit that referenced this pull request Jun 20, 2022
@apaleslimghost
Merge pull request #113 from Financial-Times/clean-up
610879e 
Clean up & document
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjparkinson sjparkinson sjparkinson approved these changes

@adambraimbridge adambraimbridge adambraimbridge approved these changes

@tom-parker tom-parker tom-parker approved these changes

@simonplend simonplend simonplend approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@apaleslimghost @sjparkinson @adambraimbridge @tom-parker @simonplend