-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NOPS-817- Handle Sample and Baseline null values. #145
Conversation
README.md
Outdated
@@ -126,7 +126,8 @@ Checks if the value of a graphite metric has received data recently. | |||
#### `cloudWatchThreshold` | |||
Checks whether the value of a CloudWatch metric has crossed a threshold | |||
|
|||
_Note: this assumes that `AWS_ACCESS_KEY` & `AWS_SECRET_ACCESS_KEY` are implictly available as environment variables on process.env_ | |||
_Note: this assumes that `AWS_ACCESS_KEY` & `AWS_SECRET_ACCESS_KEY` are implicitly main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: what does 'main' mean in this context?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another typo, fixed thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great PR description!! Thanks 🌟
…hite-null-values NOPS-817- Handle Sample and Baseline null values.
We discovered that there is a situation where we get null values for Sample and Baseline from Graphite, which we aren't handling here. If Sample and Baseline are both nulls, these conditions will be false, and
ok
will also be false. This PR adds transformNull to the graphite query and an additional check for null values. See discussion.Tickets
https://financialtimes.atlassian.net/browse/NOPS-817