[NOPS-985] Log null data in GraphiteThreshold check #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
apaleslimghost
approved these changes
Aug 23, 2021
In dev huddle today I spoke about the fact that historically we don't alert based on null data. Some people mentioned this may be due to the reliability of Graphite in the past. I'd like to log the rate that we encounter null data as part of this threshold check with the potential to reverse the behaviour if we find that it's infrequent.
alexmuller
force-pushed
the
log-null-data-in-graphitethreshold-check
branch
from
8dce3fb
to
3ae482e
Compare
|
It was @AniaMakes's great idea, I just pinched it! Also fixed the test which I inadvertently broke, sorry. |
alexmuller
changed the title
JSRedondo
pushed a commit
that referenced
this pull request
Jun 20, 2022
…ethreshold-check [NOPS-985] Log null data in GraphiteThreshold check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In dev huddle today I spoke about the fact that historically we don't alert based on null data.
Some people mentioned this may be due to the reliability of Graphite in the past. I'd like to log the rate that we encounter null data as part of this threshold check with the potential to reverse the behaviour if we find that it's infrequent.