Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FTDCS-196 - Fastly key expiration check merge #189

Merged
merged 10 commits into from
Jun 20, 2022
Merged

FTDCS-196 - Fastly key expiration check merge #189

merged 10 commits into from
Jun 20, 2022

Conversation

JSRedondo
Copy link
Contributor

We should add a check type to n-health which verifies Fastly keys using https://api.fastly.com/tokens/self:

  • alert if the key expires in the next week or two
  • alert if the key has a null expiry date

@JSRedondo JSRedondo requested a review from a team as a code owner June 20, 2022 13:13
@JSRedondo JSRedondo requested a review from a team June 20, 2022 13:13
ivomurrell
ivomurrell approved these changes Jun 20, 2022
View reviewed changes
Copy link
Contributor

@ivomurrell ivomurrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@JSRedondo JSRedondo merged commit bcb4dcb into main Jun 20, 2022
@JSRedondo JSRedondo deleted the fastly-key-expiration-check-merge branch June 20, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivomurrell ivomurrell ivomurrell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JSRedondo @ivomurrell