Skip to content
This repository has been archived by the owner on Mar 22, 2024. It is now read-only.

Fix typo in preinstall script dependency #647

Merged
merged 1 commit into from
Dec 8, 2021
Merged

Conversation

ivomurrell
Copy link
Contributor

We use the check-engine script to enforce the versions defined in the package.jsons engines field. Unfortunately, instead of installing check-engine in our devDependencies we instead were installing check-engines (note the plural) errorneously. Because we're running check-engine before the dependencies are actually installed – the first time at least – we override npm 7's prompt to confirm installing a new package and so this typo was missed. check-engines was never actually run, nor does it look like a security threat, so we don't need to do anything else, we just want to make sure we are using the correct major version of check-engine to avoid breaking changes in the future.

@ivomurrell ivomurrell requested a review from a team as a code owner December 1, 2021 14:23
@ivomurrell ivomurrell merged commit 76d1a3a into main Dec 8, 2021
@ivomurrell ivomurrell deleted the nori/singular-engine branch December 8, 2021 14:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant