Fix conflicting workspaces in publish job #191
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In theory, we want to make sure that the CircleCI tests have passed before we publish the package to npm. Unfortunately, requiring a job as a dependency of another job implicitly tells the dependent job to use the dependency's workspace layer. If we want to wait on both Node 14 and Node 16 tests to pass before starting the
publish
job, we also need to attach to both of their workspace layers, causing a conflict seeing as they install different build artefacts. There doesn't seem to be any way to explicitly specify which workspace layers you want a job to attach to, so we instead have to not require the Node 14 tests to pass before the package is published. This is less than ideal but there doesn't seem to be any way around this.Also update the
.nvmrc
file, which the latestupgrade-node
script supports.