Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conflicting workspaces in publish job #191

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

ivomurrell
Copy link
Contributor

In theory, we want to make sure that the CircleCI tests have passed before we publish the package to npm. Unfortunately, requiring a job as a dependency of another job implicitly tells the dependent job to use the dependency's workspace layer. If we want to wait on both Node 14 and Node 16 tests to pass before starting the publish job, we also need to attach to both of their workspace layers, causing a conflict seeing as they install different build artefacts. There doesn't seem to be any way to explicitly specify which workspace layers you want a job to attach to, so we instead have to not require the Node 14 tests to pass before the package is published. This is less than ideal but there doesn't seem to be any way around this.

Also update the .nvmrc file, which the latest upgrade-node script supports.

@ivomurrell ivomurrell requested a review from a team as a code owner March 17, 2022 17:31
@ivomurrell ivomurrell merged commit 39b468c into main Mar 18, 2022
@ivomurrell ivomurrell deleted the fix-conflicting-workspaces branch March 18, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants