This repository has been archived by the owner on Apr 1, 2020. It is now read-only.
If hideOutboundLinks flag set, show only an unlinked logo in header #1244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonnywyatt
requested review from
tavvy,
GlynnPhillips,
leggsimon and
rowanbeentje
There was a problem hiding this comment.
Looks ok to me.
Only small concern is duplicate of markup, but I am not really sure on a better solution.
Also, how difficult would it be to add a small test that spins this up with that flag and checks the output has no anchor tags in it? I am not familiar with testing within n-ui so I am not to sure on that.
Take this more as suggested feedback than approve or decline, Someone with more n-ui knowledge than myself would also be good to get a review from
|
I completely agree this should have a test. But N-ui has no test setup at all right now, and this change has to go live asap for GDPR compliance. I'll add a note to #1229 |
adgad
added a commit
that referenced
this pull request
Jun 6, 2018
… add-postcss-config * 'master' of https://github.com/Financial-Times/n-ui: (48 commits) Make the browser's request url available to handlebars (#1251) Fix progressive loading of the display font. (#1249) Remove o-cookie-message (#1250) bump o-ads (#1247) Bumping version of o-ads to include cookie consent check (#1246) bump o-header If hideOutboundLinks flag set, show only an unlinked logo in header (#1244) Removing Krux feature flags as features are no longer required (#1245) Bump n-syndication and n-counter-ad-blocking 🐿 v2.8.0 Revert "Deleted n-counter-ad-blocking (#1232)" Revert "Don't render My account top nav link if myFtNavigationV2 flag set (#1216)" Remove disable flags for iso and android (#1242) Add project name to browserstack karma Use latest safari for browser tests Avoid two cookie consent banners (#1240) Pa11y upgrade (#1238) Browserstack (#1237) Update mocha and nyc (#1236) make consent available on resource locals (#1235) Hide header / footer based on a flag (#1234) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🐿 v2.8.0