fix aria-label from inputs #675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boyewale
reviewed
Oct 27, 2022
| @@ -18,7 +18,7 @@ export default ({ rafTitle, rafDescription, urls, actions }) => { | |||
| value={urls.raf} | |||
| className="x-gift-article__url-input" | |||
| readOnly | |||
| aria-label="Gift free subscription shareable link" | |||
| aria-label={rafTitle} | |||
There was a problem hiding this comment.
What does rafTitle contain - any example text (i.e. what would be in props.raf?.title)?
Presumably it'll be "Share this article" instead of "Gift free subscription shareable link".
Going by this line the default would be 'Gift 2 months free access to the FT'?
There was a problem hiding this comment.
Yes it would contain the title of the section and in this case is the default .
boyewale
approved these changes
Oct 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix aria-label on inputs for voice commands so they content entirely the text of the title section where they are contained.
ticket