Bugfix: Gift Article Radio Buttons #693
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willhoward
requested review from
AnnaDraganova,
MMSaleh-FT,
umbobabo and
fabiosikansi
asugar13
requested changes
Jan 26, 2023
|
Sure! At the moment if you're a B2C customer and you're viewing a paid article you'll see this:
This isn't right because B2C customers shouldn't be seeing the 'Multiple recipients' Enterprise Sharing option. Enterprise Sharing is only available to users who are B2B or FT Staff. After the change if you're a B2C customer and you're viewing a paid article you'll see this:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug whereby B2C users were erroneously seeing the 'Enterprise Sharing' option in the Gift Article radio buttons. This was happening because the specific logic controlling which radio buttons to display was quite confusing.
I've now separated out that logic. There's some minor repetition of code which I think is justified by making the logic clearer and easier to understand. I've also added a few code comment to explain it.