Apply new origami focus styling to x-follow-button #694
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We haven't moved all myFT follow buttons to x-follow-button on ft.com yet. This causes we need to update stylings on both n-myft-ui and x-follow-button when some changes require to myftLozengeTheme. Actually some of the feature in n-myft-ui is not synced to x-follow-button. To avoid this issue, applying myftLozenge mixin from n-myft-ui.
joelcarr
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
x-follow-button has the same issue as
n-myft-ui's follow button after origami team released new focus styling across ft.com.The detail is in this n-myft-ui PR.
This PR is to apply the same changes in
n-myft-uitox-follow-button.We always need to update two repos (
n-myft-ui&x-follow-button) when some changes inmyftLozengemixins.x-follow-buttonwas originally created to replace all the n-myft-ui follow buttons on ft.com however we haven't done that yet. It causes some features are unsynced because we forget to update two of them.To avoid the issue, we should use
n-myft-ui'smyftLozengemixins until we move all the follow button tox-follow-button.This PR has two parts
Remove own
⚠️ Need to check no difference between own ones and
myftLozengemixins, change to usen-myft-ui's mixinsn-myft-uionesUpdate
n-myft-uito the latest version to apply new focus styling fromo-normalise&o-buttons1. Remove own
myftLozengemixins, change to usen-myft-ui's mixinsNo big difference when I replaced the own lozenge mixins to n-myft-ui ones.
Only this n-myft-ui change had been forgotten to sync to x-follow-button.
aria-pressed=falsearia-pressed=true2. Update
n-myft-uito the latest version to apply new focus styling fromo-normalise&o-buttonsaria-pressed=falsearia-pressed=true