Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show View Enterprise Links at every ES stage #698

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Show View Enterprise Links at every ES stage #698

merged 1 commit into from
Mar 29, 2023

Conversation

AnnaDraganova
Copy link
Contributor

Description

  • Fixed the issue with 'View all Enterprise links' not showing up in the gift-article modal once link is created.
  • The message for successful copy was made to appear above the 'View all Enterprise links' matching the design

Screenshots

Screenshot 2023-03-28 at 16 03 47

Screenshot 2023-03-28 at 15 22 10

Link to the task

https://financialtimes.atlassian.net/browse/ENTST-301

@AnnaDraganova AnnaDraganova requested a review from a team as a code owner March 28, 2023 13:04
@next-team next-team temporarily deployed to x-dash-entst-301-enterp-wgia8a March 28, 2023 13:04 Inactive
magsallen
magsallen approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@magsallen magsallen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the screenshots!

AniaMakes
AniaMakes approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@AniaMakes AniaMakes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need to admit it's been a long time since I worked with x-gift-article. The code looks reasonable, but I think it may be best that once you ingest it into next-article, you check everything works in prod as expected.

@AnnaDraganova
Copy link
Contributor Author

I need to admit it's been a long time since I worked with x-gift-article. The code looks reasonable, but I think it may be best that once you ingest it into next-article, you check everything works in prod as expected.

Yes, I will check everything. Can you merge the PR since I don't have permissions?

@AniaMakes AniaMakes merged commit 0934ff6 into main Mar 29, 2023
@AniaMakes AniaMakes deleted the ENTST-301-enterprise-links-design-issues branch March 29, 2023 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magsallen magsallen magsallen approved these changes

@AniaMakes AniaMakes AniaMakes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@AnnaDraganova @magsallen @AniaMakes @next-team