remove page reload when saving highlights #711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkerr321
reviewed
Jun 12, 2023
| localStorage.setItem('showSuccessSavedMessage', 'true') | ||
| location.href = url.toString() | ||
| dispatchEvent(new CustomEvent('removeHighlightsSave')) |
There was a problem hiding this comment.
question: why are we dispatching this event?
There was a problem hiding this comment.
this event a is used in the editor package to remove the the save highlights message when the highlights are saved in the article modal
jkerr321
approved these changes
Jun 13, 2023
jkerr321
approved these changes
Jun 13, 2023
AniaMakes
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
I'm approving, but with a caveat that I have very little context of this work (even after reading the ticket). It looks like ENTST people know what they want to do, and @jkerr321 approved already - so I'm going to add my token 👍🏻
jkerr321
deleted the
ENTST-513-sharing-highlights-page-reloads-when-uses-saves-highlights-via-the-share-modal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changes to x-gift-article component
ticket