Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update x/foundation params #704

Merged
merged 29 commits into from
Oct 18, 2022
Merged

Conversation

0Tech
Copy link
Collaborator

@0Tech 0Tech commented Oct 11, 2022

Description

This patch would:

  • Modify Params.
    • Remove Enabled in favor of the fine-grained alternative.
    • Add CensoredMsgTypeUrls which contains the message type urls of the messages under the censorship.
      • You cannot add the message after the chain started, meaning you must add the message into the genesis.
      • Removing the message from it is allowed, accompanied by the deletion of the corresponding authorizations from the state.
  • Revisit genesis.
    • FoundationInfo must be supplied, and its contents must be valid.
      • You must provide the operator address explicitly.
      • The foundation operator must be a module account.
    • Stop providing auto-generated entities:
      • CreateValidatorAuthorizations.
      • The foundation members.
  • Remove the unused internal function UpdateOperator().
  • Use MustAccAddressFromBech32().

Checklist:

  • I followed the contributing guidelines and code of conduct.
  • I have added a relevant changelog to CHANGELOG.md
  • I have added tests to cover my changes.
  • I have updated the documentation accordingly.
  • I have updated API documentation client/docs/swagger-ui/swagger.yaml

@0Tech 0Tech self-assigned this Oct 11, 2022
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #704 (d06ef0d) into main (ef55766) will increase coverage by 0.04%.
The diff coverage is 97.53%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #704      +/-   ##
==========================================
+ Coverage   61.96%   62.00%   +0.04%     
==========================================
  Files         874      874              
  Lines       98797    98608     -189     
==========================================
- Hits        61215    61139      -76     
+ Misses      33938    33857      -81     
+ Partials     3644     3612      -32     
Impacted Files Coverage Δ
x/foundation/codec.go 0.00% <0.00%> (ø)
x/foundation/keeper/handler.go 14.28% <ø> (+4.28%) ⬆️
x/foundation/keeper/keeper.go 83.33% <ø> (ø)
x/foundation/keeper/proposal.go 82.94% <33.33%> (+4.53%) ⬆️
x/stakingplus/keeper/msg_server.go 81.25% <57.14%> (ø)
x/foundation/genesis.go 83.67% <96.87%> (+7.25%) ⬆️
simapp/app.go 86.14% <100.00%> (ø)
x/foundation/client/testutil/grpc.go 92.68% <100.00%> (+0.57%) ⬆️
x/foundation/client/testutil/query.go 100.00% <100.00%> (ø)
x/foundation/client/testutil/suite.go 97.84% <100.00%> (-0.07%) ⬇️
... and 22 more

@0Tech 0Tech marked this pull request as ready for review October 11, 2022 06:20
CHANGELOG.md Show resolved Hide resolved
x/foundation/genesis.go Outdated Show resolved Hide resolved
x/foundation/genesis.go Outdated Show resolved Hide resolved
@0Tech 0Tech requested a review from zemyblue October 14, 2022 06:40
x/foundation/keeper/params.go Show resolved Hide resolved
x/foundation/proposal.go Show resolved Hide resolved
@zemyblue
Copy link
Member

Please update lbm also.

@0Tech 0Tech requested a review from zemyblue October 17, 2022 02:19
@0Tech 0Tech merged commit 15168bf into Finschia:main Oct 18, 2022
@0Tech 0Tech deleted the foundation_params branch October 18, 2022 03:39
@zemyblue zemyblue added the C:x/foundation x/foundation module label Oct 24, 2022
@zemyblue zemyblue mentioned this pull request Oct 27, 2022
5 tasks
@zemyblue zemyblue mentioned this pull request Nov 28, 2022
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C:x/foundation x/foundation module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants