chore: update build args to arm64 #157
Merged
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zemyblue
reviewed
Mar 28, 2023
zemyblue
reviewed
Mar 28, 2023
zemyblue
reviewed
Mar 28, 2023
I added a note to the README that the build default is Intel mac. |
zemyblue
previously approved these changes
Mar 28, 2023
jaeseung-bae
previously approved these changes
Mar 28, 2023
torao
reviewed
Mar 28, 2023
…date-m1-build-args
zemyblue
approved these changes
Mar 29, 2023
jaeseung-bae
approved these changes
Mar 29, 2023
zemyblue
added a commit
to zemyblue/finschia
that referenced
this pull request
Apr 21, 2023
* rc/v1.0.0-rc0: (26 commits) ci: add a ci to build darwin version when add tag (Finschia#180) chore: Release v1.0.0-rc7 (Finschia#179) Bump github.com/Finschia/finschia-sdk from v0.47.0-rc6 to v0.47.0-rc7 (Finschia#178) chore: Release v1.0.0-rc6 (Finschia#177) build: rename and bump up dependencies (Finschia#176) chore: bump up lbm-sdk from v0.47.0-rc5 to v0.47.0-rc5.0.20230414034539-489c442416cd (Finschia#174) chore: Release v1.0.0-rc5 (Finschia#173) Bump github.com/line/lbm-sdk from v0.47.0-rc4.0.20230410115856-b8421116b3f2 to v0.47.0-rc5 (Finschia#172) chore: apply wasmd v0.1.2 (Finschia#171) fix license copyright holder and typo (Finschia#170) Bump github.com/line/lbm-sdk from v0.47.0-rc4 to v0.47.0-rc4.0.20230410115856-b8421116b3f2 (Finschia#168) Bump up github.com/line/lbm-sdk from v0.47.0-rc3 to v0.47.0-rc4 (Finschia#167) chore: release v1.0.0-rc3 (Finschia#166) feat: bump up ibc-go v3.3.2 and wasmd for changing ibc light client of Ostracon to Tendermint (Finschia#164) chore: update license notice and code_of_conduct (Finschia#165) Bump github.com/line/lbm-sdk from v0.47.0-rc2 to v0.47.0-rc3 (Finschia#162) fix: fix `release-build` ci error occurred when adding assets after tagging (Finschia#163) chore: release v1.0.0-rc2 (Finschia#160) Bump github.com/line/lbm-sdk from v0.47.0-rc1 to v0.47.0-rc2 (Finschia#159) chore: update build args to arm64 (Finschia#157) ...
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#155
I changed the build args default to M1 mac.
To run it on an M1 mac simply run:
make build-dockerFor Intel mac, specify args as follows and execute.
make build-docker ARCH=x86_64 PLATFORM=amd64Change default to intel mac.
For M1 mac, please see README.
Description
Motivation and context
How has this been tested?
Screenshots (if appropriate):
Checklist: