Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge CQL-to-ELM updates into develop-2.0 from the scopes-2.0 branch Integration tests passing [1251 / 1822] #419

Merged
merged 10 commits into from
Jul 26, 2024

Conversation

EvanMachusak
Copy link
Collaborator

Changes to CqlToElm & ephemeral projects to support translation of 400 HEDIS libraries.

@EvanMachusak EvanMachusak linked an issue Jul 25, 2024 that may be closed by this pull request
@EvanMachusak EvanMachusak self-assigned this Jul 25, 2024
@EvanMachusak EvanMachusak added this to the 2.0 (September WGM) milestone Jul 25, 2024
MinValue or MaxValue => [], // type is a generic type arg

// special expression types
UnaryWithPrecision uwp => [uwp.operand, uwp.GetPrecision()],
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

@baseTwo
Copy link
Collaborator

baseTwo commented Jul 25, 2024

TODO - Check that the CMS measures compile

@baseTwo baseTwo changed the title CQL-to-ELM updates into develop-2.0 Merge CQL-to-ELM updates into develop-2.0 from the scopes-2.0 branch Jul 26, 2024

// all functions still take the bundle and context parameters, plus whatver the operands
// to the actual function are.

Copy link
Collaborator

@baseTwo baseTwo Jul 26, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The logic here is preventing the demo projects from compiling. I'll have to create an issue to revert it back to the original code, and there is already a ticket for the future to try to get this right #397

Copy link
Collaborator

@baseTwo baseTwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll have to revert the InvokeDefinedFunctionThroughRuntimeContext to what is was before #422, then it can be fixed at a later stage. As it is now, the demo projects don't compile

@baseTwo baseTwo merged commit ab0297c into develop-2.0 Jul 26, 2024
2 checks passed
@baseTwo baseTwo deleted the scopes-2.0 branch July 26, 2024 09:32
@baseTwo baseTwo changed the title Merge CQL-to-ELM updates into develop-2.0 from the scopes-2.0 branch Merge CQL-to-ELM updates into develop-2.0 from the scopes-2.0 branch [1251 / 1822] Jul 31, 2024
@baseTwo baseTwo changed the title Merge CQL-to-ELM updates into develop-2.0 from the scopes-2.0 branch [1251 / 1822] Merge CQL-to-ELM updates into develop-2.0 from the scopes-2.0 branch Integration tests passing [1251 / 1822] Jul 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Merge scopes branch into develop-2.0
2 participants