Fix 499 - generating parameter names for external functions #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… middle of the string when the type names are keywords
ewoutkramer
approved these changes
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating an automatic parameter name for a generic type, we strip the
@character if it was added normalizing the generic type argument name (e.g., because it's a C# keyword likedecimal). Example of a bad name wasnullable_@decimalwhich is now produced asnullable_decimal.Also made the
definitionsparameter ofAssemblyCompiler.Compileno longer optional. When not specified, the function does nothing.Tested by CqlToElmTests/FunctionDefinitionTest/External_Function