feat: expose TypeResolver and TypeConverts #80
Conversation
| @@ -18,8 +18,10 @@ | |||
|
|
|||
| namespace Hl7.Cql.Fhir | |||
| { | |||
| internal static class FhirTypeConverter | |||
| public static class FhirTypeConverter | |||
There was a problem hiding this comment.
Can you remove the
#pragma warning disable CS1591 // Missing XML comment for publicly visible type or member
from the top of the file and document this class?
There was a problem hiding this comment.
Sure, I will update it in a subsequent PR.
| @@ -13,9 +13,9 @@ | |||
| using Hl7.Fhir.Model; | |||
| namespace Hl7.Cql.Packaging | |||
| { | |||
| internal class CqlCrosswalk | |||
| public class CqlCrosswalk | |||
There was a problem hiding this comment.
Can you remove the
#pragma warning disable CS1591 // Missing XML comment for publicly visible type or member
from the top of the file and document this class?
There was a problem hiding this comment.
Sure, I will update it in a subsequent PR.
| @@ -247,7 +247,7 @@ public CqlCrosswalk(TypeResolver typeResolver) | |||
| } | |||
| } | |||
|
|
|||
| internal class TypeEntry | |||
| public class TypeEntry | |||
There was a problem hiding this comment.
This feels like a record. We should remove the setters for the properties. Maybe we can even make this a record class?
There was a problem hiding this comment.
yes, this could definitely be a record type. I will update it in a subsequent PR.
| @@ -13,9 +13,9 @@ | |||
| using Hl7.Fhir.Model; | |||
| namespace Hl7.Cql.Packaging | |||
| { | |||
| internal class CqlCrosswalk | |||
| public class CqlCrosswalk | |||
There was a problem hiding this comment.
These classes do feel like internal utility classes to me. What are they? A kind of mapping from a FHIR type to a CQL type? Should this also work for other models?
There was a problem hiding this comment.
Yes, it's a mapping between FHIR and CQL types. We use it to convert our generated outputs to the data model our customers want (FHIR or CQL). I could see it expanding to other data models in the future, but I would think we'd need create a parent and rename this "FhirCqlCrosswalk", which is what it used to be named.
|
Oops, I didn't mean to merge it yet ;-) Now we need another PR to fix my remarks. Don't know what happened there... Interesting, I didn't. It's an automated message, I requested changes, but by doing so, I fulfilled some requirement and it got merged automatically. Mmmmm..... |
Very strange. I'll work on a PR soon to get these items fixed. |
At NCQA, our existing DCS software utilizes the TypeResolver and TypeConverter classes. We use these to convert between the CQL and FHIR data models in various parts of our application. This PR is to expose the minimum set of classes/methods that we need publicly.