Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated functions url and ugettext_lazy #3976

Merged
merged 3 commits into from
May 18, 2024

Conversation

gagantrivedi
Copy link
Member

@gagantrivedi gagantrivedi commented May 17, 2024

Thanks for submitting a PR! Please check the boxes below:

  • I have run pre-commit to check linting
  • I have added information to docs/ if required so people know about the feature!
  • I have filled in the "Changes" section below?
  • I have filled in the "How did you test this code" section below?
  • I have used a Conventional Commit title for this Pull Request

Changes

  • Replace django.conf.urls url with django.urls.re_path
  • Replace ugettext_lazy with gettext_lazy

Note: ugettext_lazy and url were deprecated in Django 3.x.

How did you test this code?

covered by existing unit tests( 🤞 )

ugettext_lazy and url were deprecated in Django 3.x.
Copy link

vercel bot commented May 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 11:13am
flagsmith-frontend-preview ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 11:13am
flagsmith-frontend-staging ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 17, 2024 11:13am

Copy link
Contributor

github-actions bot commented May 17, 2024

Uffizzi Preview deployment-51887 was deleted.

Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.18%. Comparing base (231af3b) to head (ac7a3c5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3976   +/-   ##
=======================================
  Coverage   96.18%   96.18%           
=======================================
  Files        1141     1141           
  Lines       36507    36495   -12     
=======================================
- Hits        35114    35103   -11     
+ Misses       1393     1392    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

api/app/urls.py Outdated Show resolved Hide resolved
api/environments/models.py Outdated Show resolved Hide resolved
api/features/models.py Outdated Show resolved Hide resolved
api/users/urls.py Outdated Show resolved Hide resolved
Co-authored-by: Matthew Elwell <matthew.elwell@flagsmith.com>
@gagantrivedi gagantrivedi added this pull request to the merge queue May 18, 2024
Merged via the queue into main with commit e613eec May 18, 2024
24 checks passed
@gagantrivedi gagantrivedi deleted the chore/replace-deprecated-url branch May 18, 2024 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Issue related to the REST API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants