infra: run influxdb feature evaluation in thread #4125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Ignored Deployments
|
|
Uffizzi Preview |
gagantrivedi
approved these changes
Jun 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4125 +/- ##
=======================================
Coverage 96.44% 96.44%
=======================================
Files 1149 1149
Lines 37596 37619 +23
=======================================
+ Hits 36259 36282 +23
Misses 1337 1337 ☔ View full report in Codecov by Sentry. |
matthewelwell
deleted the
infra/run-influx-db-feature-evaluation-in-thread
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a PR! Please check the boxes below:
pre-committo check lintingdocs/if required so people know about the feature!Changes
Due to large amounts of throughput from tracking feature evaluation requests in influx db, we're reverting this task to run in thread.
How did you test this code?
Updated some unit tests to verify that the call to run_in_thread is happening correctly