-
-
Notifications
You must be signed in to change notification settings - Fork 140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate to TypeScript version 3, fix MariaDB tests & use Github Actions #557
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v1-3-0 #557 +/- ##
=========================================
Coverage ? 99.57%
=========================================
Files ? 88
Lines ? 1636
Branches ? 371
=========================================
Hits ? 1629
Misses ? 7
Partials ? 0 Continue to review full report at Codecov.
|
LoicPoullain
changed the title
Migrate to TypeScript version 3.
Migrate to TypeScript version 3 & Use Github Actions
Oct 25, 2019
LoicPoullain
changed the title
Migrate to TypeScript version 3 & Use Github Actions
Migrate to TypeScript version 3, fix MariaDB tests & use Github Actions
Oct 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
unknown
required). This makes the build of@foal/typestack
fail with TS@v2.Solution and steps
Starting from v1.3.0, FoalTS will only support TS@3.5 and beyond. This should not break current applications because most of them use TS@3.5 and beyond and the others that use TS@2.9 will only need to run
npm run typescript@3
to go to the new version without breaking changes (TS@3 is highly compatible with TS@2.9).Checklist