-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: Possibility to use <i> by replacing it with <svg> to make it more flexible #424
Comments
See option 2 in the https://github.com/FortAwesome/angular-fontawesome/blob/master/docs/guide/advanced-uses.md#replace-i-tags-with-icons-in-the-arbitrary-html. Not 100% sure it will work with PrimeNG, but I guess it should if PrimeNG generates the correct markup 🤔 Whether it will work with dynamic property updates is another question. This approach also has performance caveats, so use with care. I don't think we'll be offering a better integration between the Angular component and the In summary, there are three approaches:
For an average Angular project I would recommend (1) with a solution described in the linked doc page (where needed). For a project where most of the icons are dynamic and come in PS Another issue about PrimeNG - #117 |
primefaces/primeng#4588 (comment) claims that custom icons are fixed in v10, although it's not very clear how exactly it is "fixed" 😄 UPD https://primeng.org/customicons#fontawesome, pretty sure this approach will work just fine with |
Describe the problem you'd like to see solved or task you'd like to see made easier
I know the following issue has been completed but I think we still need to be able to use the <i> tag like on the official SVG Package, see documentation: SVG Core Plugins page.
Avantages :
Is this in relation to an existing part of angular-fontawesome or something new?
Something new for this package, but existing in the official FontAwesome SVG plugin.
What is 1 thing that we can do when building this feature that will guarantee that it is awesome?
By behind more flexible, it won't force developers to use both angular-fontawesome AND Web Font package for example (@fortawesome/fontawesome-free) or choose between one or the other.
Why would other angular-fontawesome users care about this?
No need to hesitate between the official package and this one.
On a scale of 1 (sometime in the future) to 10 (absolutely right now), how soon would you recommend we make this feature?
9, that's the main reason why i don't recommend the usage of this library in my clients projects and i must use Web Font or Official SVG one to preserve DX and make it usable for PrimeNG (for example).
Feature request checklist
Feature request: moar cowbell
)The text was updated successfully, but these errors were encountered: