Replace http-parser with llhttp #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muneebahmed10
force-pushed
the
replace-parser
branch
from
43514f8
to
17a0810
Compare
muneebahmed10
force-pushed
the
replace-parser
branch
2 times, most recently
from
13427ea
to
005adcc
Compare
muneebahmed10
force-pushed
the
replace-parser
branch
from
005adcc
to
1227e7a
Compare
archigup
approved these changes
Jan 24, 2022
n9wxu
approved these changes
Jan 25, 2022
aggarg
added a commit
that referenced
this pull request
Apr 7, 2022
* Replace http-parser with llhttp (#126) * Add llhttp submodule * Replace http-parser with llhttp in source * Fix CI checks * Fix unit tests 100% coverage * Rename functions * Disable strict mode * Remove http-parser submodule * Update CBMC proofs for llhttp (#127) * Update CBMC proofs * Update execute mocks * Rename stub file * Return error fields from stubs * Remove unused variable (#128) * Remove unused variable * Void unused status code * Address review comments Signed-off-by: Gaurav Aggarwal <aggarg@amazon.com> Co-authored-by: Muneeb Ahmed <54290492+muneebahmed10@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Replaces http-parser with llhttp. Unit tests are at 100% coverage, however, they mock out the parser and assume its outputs. End-to-end tests that do not use a mocked parser have not yet been added to coreHTTP. Using llhttp requires C99, so this library will need to use C99 at minimum as well. CBMC checks will fail as those have not been updated