Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overset sometimes returns true even if content did fit the last region #33

Open
pussmun-12 opened this issue Mar 22, 2016 · 3 comments
Open
Assignees
Labels

Comments

@pussmun-12
Copy link

Hi,

I am working on a pen on Codepen, which is not working properly.
The pen is working fine in browsers that support css regions, but not using your polyfill.
The pen tries to create divs (css-regions) on the fly - and then trying to fill them with text.
I would be most thankful if you can have a look at this pen:

http://codepen.io/pussmun/pen/WwpYor

@gpeche
Copy link

gpeche commented Jun 17, 2016

Hi,

I just had a look at your Codepen and I think your problem is the same I have suffered. Look at #35 for more details

@FremyCompany
Copy link
Owner

I just had a look, and that was it. I was totally puzzled by this one, because when I tried to reproduce locally I didn't use uppercased letters in the flow name, and concluded it must have been something due to the Codepen.

There is still a remaining issue once this one is fixed (and once the assumption the polyfill runs synchronously is removed) so I'll keep this issue open with an new title to track this other issue:
http://codepen.io/FremyCompany/pen/gMwOvq

@FremyCompany FremyCompany changed the title Overset is always false - perhaps my code is too dynamic? Overset sometimes returns true even if content did fit the last region Jun 17, 2016
@FremyCompany FremyCompany self-assigned this Jun 17, 2016
@pussmun-12
Copy link
Author

Thank you - it looks very promising; now working in Chrome.

2016-06-17 19:30 GMT+02:00 François REMY notifications@github.com:

I just had a look, and that was it. I was totally puzzled by this one,
because when I tried to reproduce locally I didn't use uppercased letters
in the flow name, and concluded it must have been something due to the
Codepen.

There is still a remaining issue once this one is fixed (and once the
assumption the polyfill runs synchronously is removed) so I'll keep this
issue open with an new title to track this other issue:
http://codepen.io/FremyCompany/pen/gMwOvq


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#33 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/ADNiNgLQraelamnONw9sb3wiV3U7QOtbks5qMtmqgaJpZM4H13GG
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants