-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add multiple success failures types #41
Conversation
This reverts commit 104e1c3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👏 👏 Awesome!
I have a question though, does this change breaks compatibility with the current version?
Co-authored-by: Matheus Batista <matheusbattista@hotmail.com>
@matheusbsilva Thanks for reviewing this ❤️ Man, the idea is to keep compatibility... Providing just this new deprecation warning: https://github.com/Fretadao/f_service/pull/41/files#diff-53c2e1dfdeb23d78fffd5f40d1602d38df5bd3f5d9903d8ab3bcf52402bb473cR24 I've tested on some services from our Web system, and seems that it's working... Could you test it against our Kippu system also? Just pointing the Gemfile to this branch: gem 'f_service', github: 'Fretadao/f_service', branch: 'bv-add-multiple-failures' updating and run the system. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🥇
Allow Success, Failure, Check and Try to be multiple Types.
Closes issue: #39
This allows success or failure to be more than one type...
A real-world example of this use is an HTTP client where we want to give provide different rescues for different HTTP codes, but same treatment for any other code for the family. For example: