Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to filter by group #39

Merged
merged 1 commit into from
Feb 25, 2021

Conversation

askvortsov1
Copy link
Contributor

Fixes #10

Changelog:

  • Added GroupIDGambit, as otherwise we can't support groups with spaces in the name
  • Added logic and UI for group filtering (using group ID gambit)

Demo Video:
https://youtu.be/tIkyLAFA8cE

@askvortsov1
Copy link
Contributor Author

I'm considering expanding this so that stuff like #5 (the filter by suspend especially) could be added; we'd have dividers in between groups of buttons, the first group would be for groups, and others, like suspended status, could be added

Copy link
Member

@clarkwinkelmann clarkwinkelmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be more logical to add the gambit to core, and only the controls to User Directory

src/Search/Gambit/GroupIdGambit.php Outdated Show resolved Hide resolved
@clarkwinkelmann
Copy link
Member

@askvortsov1 are you interested in updating this to use the new native group gambit?

Maybe you'll want to create a new PR for that. Feel free to close this one.

@askvortsov1
Copy link
Contributor Author

Updated

Copy link
Member

@imorland imorland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checked out locally, appears to be as intended 👍

Thanks @askvortsov1

@imorland imorland merged commit 54c86fb into FriendsOfFlarum:master Feb 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Sorting users based on roles
3 participants