Fix URL encoding to mimic Symfony URL Generator #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tobias-93 Friendly ping. Can you review this? |
|
Hi @ajgarlag, looks good to me! Could you rebase, so I can merge it? Thanks! |
ajgarlag
force-pushed
the
fix-url-encoding
branch
from
f815ccf
to
97a1cea
Compare
|
Thanks @ajgarlag |
|
Thanks @tobias-93 for merging it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #385 testing that the generated URL mimic the one generated by Symfony URL Generator.
This PR improves #386
After this PR, spaces in query parameters are encoded as
%20instead of+