New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neopixel_caselight_enable #541

Open

Benoitone wants to merge 4 commits into develop from neopixel_caselight_enable

Collaborator

Benoitone commented Mar 9, 2024

if no toolhead light is selected in printer.cfg and only one of the 2 types of neopixel caselight is included then no lighting will be active in the macros.


          fix for enabled in all macros neopixel caselight lights without toolh…

94b52ea

…ead lights

Benoitone added the bug label

Benoitone mentioned this pull request

STATUS_LEDS not called when using neopixel_caselight_effects.cfg without status_leds*.cfg #537

Closed

1 task

Benoitone requested a review from Frix-x

March 9, 2024 11:15

Benoitone added 2 commits

March 14, 2024 22:57


          Merge branch 'develop' into neopixel_caselight_enable

d9ed423


          Merge branch 'develop' into neopixel_caselight_enable

2e26d87

Owner

Frix-x commented Mar 20, 2024

Hello there is also #561 that was open. Can you have a look and tell me which option is better? Or maybe merge both into a global new PR with the best of both?

I'm not using neopixels on my machines so I can't test that much this kind of things...

Frix-x mentioned this pull request

Option to use RGB caselights as status LEDs #561

Open


          Merge branch 'develop' into neopixel_caselight_enable

3011cd3

Collaborator Author

Benoitone commented Mar 20, 2024

Hello there is also #561 that was open. Can you have a look and tell me which option is better? Or maybe merge both into a global new PR with the best of both?

I'm not using neopixels on my machines so I can't test that much this kind of things...

Hello, I don't really see the point of adding a variable in variables.cfg...
For me, the modification made solves the problem encountered and seems to me to be entirely compatible with the different possible configurations.

Collaborator Author

Benoitone commented Mar 21, 2024 •

edited

Loading

@Frix-x @mattpolito maybe we can make a common PR with #563 :
If @mattpolito want to make is PR modified in neopixel_caselight_enable branch??? with:

[gcode_macro _INIT_LEDS]
gcode:
    {% if printer["gcode_macro _USER_VARIABLES"].neopixel_leds_enabled or printer["gcode_macro _USER_VARIABLES"].light_enabled %}
        {% if printer["gcode_macro _USER_VARIABLES"].caselight_on_at_startup|default(False) %}
            {% if printer["gcode_macro _USER_VARIABLES"].light_enabled %}
                LIGHT_ON
            {% endif %}
            {% if printer["gcode_macro _USER_VARIABLES"].neopixel_leds_enabled %}
                STATUS_LEDS COLOR="READY"
            {% endif %}
        {% else %}
            {% if printer["gcode_macro _USER_VARIABLES"].light_enabled %}
                LIGHT_OFF
            {% endif %}
            {% if printer["gcode_macro _USER_VARIABLES"].neopixel_leds_enabled %}
                STATUS_LEDS COLOR="OFF"
            {% endif %}
        {% endif %}
    {% endif %}

github-actions bot commented Apr 21, 2024

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

5 similar comments

github-actions bot commented May 21, 2024

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

github-actions bot commented Jun 21, 2024

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

github-actions bot commented Jul 21, 2024

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

github-actions bot commented Aug 21, 2024

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

github-actions bot commented Sep 22, 2024

📌 This pull request has been marked as stale because it has not had activity in the past 30 days.
Please update the PR or comment to keep it active. Otherwise, this will be closed in 14 days.
We appreciate your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug