feature(tap) Added chaoticlab CNC tap settings. #632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Why is this needed vs just straight up overriding the [probe] block? |
# Conflicts: # config/hardware/probes/chaoticlab-cnc-tap-v2.cfg
I did exactly that, but in the nature of providing out the box support for everyone that uses these mods, I thought it would be helpful. You could say the same thing about anny klippain config file. |
|
📌 This pull request has been marked as stale because it has not had activity in the past 30 days. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding the choatic lab cnc probe, which has a higher threshold as it is more prone to failure on gantry checking and height maps.
It used the base voron_tap, so all the macros and pin settings remain.