Wrap sph2grd #1434
Merged
Wrap sph2grd #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove GMTInvalidInput import statement
Remove the use of grdinfo and use xarray min, max, median, and mean functions to test data in outgrid
maxrjones
reviewed
Sep 10, 2021
Co-authored-by: Meghan Jones <meghanj@alum.mit.edu>
weiji14
reviewed
Sep 25, 2021
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
weiji14
approved these changes
Sep 26, 2021
There was a problem hiding this comment.
Looks ready for final review. Just some minor comments to fix the lint error and add some common aliases.
Also, remember to cache the @EGM96_to_36.txt dataset as mentioned in #1434 (comment). You can do it directly in this PR instead of opening a new one.
weiji14
added
the
final review call
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
seisman
reviewed
Sep 26, 2021
seisman
reviewed
Sep 26, 2021
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
seisman
approved these changes
Sep 27, 2021
willschlitzer
removed
the
final review call
5 tasks
sixy6e
pushed a commit
to sixy6e/pygmt
that referenced
this pull request
Dec 21, 2022
Wrapping the sph2grd function. *Add sph2grd tests *Wrap required and common aliases *Add sph2grd to API index Co-authored-by: Meghan Jones <meghanj@alum.mit.edu> Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com> Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request wraps the GMT module
sph2grd.Preview docs at https://pygmt-git-wrap-sph2grd-gmt.vercel.app/api/generated/pygmt.sph2grd.html
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.Slash Commands
You can write slash commands (
/command) in the first line of a comment to performspecific operations. Supported slash commands are:
/format: automatically format and lint the code/test-gmt-dev: run full tests on the latest GMT development version