Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CITATION.cff file for PyGMT #1592

Merged
merged 5 commits into from
Oct 29, 2021
Merged

Add CITATION.cff file for PyGMT #1592

merged 5 commits into from
Oct 29, 2021

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Oct 28, 2021

Description of proposed changes

Human- and machine-readable citation information for software! Generated using doi2cff and modified slightly to cff 1.2.0 schema, see https://github.com/citation-file-format/citation-file-format/blob/1.2.0/schema-guide.md for details.

Preview the 'Cite this repository' button at https://github.com/GenericMappingTools/pygmt/tree/citation-cff

image

You can validate that the CITATION.cff has the correct schema following https://github.com/citation-file-format/cff-converter-python/tree/2.0.0#validating-a-remote-citationcff-file, e.g. with this command:

cffconvert --validate --url  https://github.com/GenericMappingTools/pygmt/raw/citation-cff/CITATION.cff

Fixes #1403

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

Human- and machine-readable citation information
for software. Generated using `doi2cff` and modified
slightly to cff 1.2.0 schema, see
https://github.com/citation-file-format/citation-file-format/blob/1.2.0/schema-guide.md
for details.
@weiji14 weiji14 added the documentation Improvements or additions to documentation label Oct 28, 2021
@weiji14 weiji14 self-assigned this Oct 28, 2021
Copy link
Member Author

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a bit last minute for PyGMT v0.5.0, so not counting on getting this in unless people are keen :)

Comment on lines +63 to +68
date-released: 2021-08-07
doi: 10.5281/zenodo.5162003
license: BSD-3-Clause
repository-code: https://github.com/GenericMappingTools/pygmt
type: software
version: 0.4.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can modify this to use the v0.5.0 DOI and date if that's preferable.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do update it for tomorrow's release

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, maybe better to change it in the PyGMT v0.5.0 changelog PR. Here's the diff for reference.

Suggested change
date-released: 2021-08-07
doi: 10.5281/zenodo.5162003
license: BSD-3-Clause
repository-code: https://github.com/GenericMappingTools/pygmt
type: software
version: 0.4.1
date-released: 2021-10-29
doi: 10.5281/zenodo.5607255
license: BSD-3-Clause
repository-code: https://github.com/GenericMappingTools/pygmt
type: software
version: 0.5.0

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On second thought, maybe better to change it in the PyGMT v0.5.0 changelog PR.

I agree.

@maxrjones
Copy link
Member

Thanks, @weiji14! Will this need to be manually updated for each release? If so, could you please add this to the release checklists in the GitHub template and maintenance guide?

@weiji14 weiji14 mentioned this pull request Oct 28, 2021
35 tasks
@weiji14
Copy link
Member Author

weiji14 commented Oct 28, 2021

Thanks, @weiji14! Will this need to be manually updated for each release? If so, could you please add this to the release checklists in the GitHub template and maintenance guide?

Ok, done in b12c568.

@@ -20,7 +20,7 @@ assignees: ''
- [ ] Reserve a DOI on [Zenodo](https://zenodo.org) by clicking on "New Version"
- [ ] Finish up 'Changelog entry for v0.x.x' Pull Request:
- [ ] Add a new entry in `doc/_static/version_switch.js` for documentation switcher
- [ ] Update citation information https://github.com/GenericMappingTools/pygmt#citing-pygmt
- [ ] Update `CITATION.cff` and BibTeX at https://github.com/GenericMappingTools/pygmt#citing-pygmt
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we really want to maintain the citation information at these two places? The 'Cite this repository' button can already generate the BibTeX information.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes? I don't like the formatting from the Export to BibTeX, it doesn't wrap the authors list. Also, I think it's good to have the BibTeX on PyPI. But maybe get a second opinion on this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the pros and cons of using CITATION.cff instead of BibTeX information, but I think we should err on the side of providing users with more options. I think that releases are few and far between, so adding a few extra parameters to update won't be that much of a demand for maintainers.

@seisman seisman added this to the 0.5.0 milestone Oct 29, 2021
doc/maintenance.md Outdated Show resolved Hide resolved
doc/maintenance.md Outdated Show resolved Hide resolved
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me except two typos above.

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Oct 29, 2021
Copy link
Contributor

@willschlitzer willschlitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending the changes recommended by @seisman

weiji14 and others added 2 commits October 29, 2021 22:29
Co-Authored-By: Dongdong Tian <seisman.info@gmail.com>
@weiji14 weiji14 merged commit 9269fbc into main Oct 29, 2021
@weiji14 weiji14 deleted the citation-cff branch October 29, 2021 09:51
@weiji14 weiji14 mentioned this pull request Oct 29, 2021
12 tasks
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Mar 18, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Human- and machine-readable citation information
for software. Generated using `doi2cff` and modified
slightly to cff 1.2.0 schema, see
https://github.com/citation-file-format/citation-file-format/blob/1.2.0/schema-guide.md
for details.

* Document that CITATION.cff needs to be updated every release

Co-authored-by: Will Schlitzer <schlitzer90@gmail.com>
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make a CITATION.cff file for PyGMT
4 participants