Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update text symbol gallery example #1648

Merged
merged 9 commits into from
Dec 10, 2021
Merged

Update text symbol gallery example #1648

merged 9 commits into from
Dec 10, 2021

Conversation

michaelgrund
Copy link
Member

Description of proposed changes

According to a recent forum post, here's an update for the text symbol gallery example. Since it is not fully clear from the current example how to change the outline color of the symbols, for the last symbol now the outline color is changed and the docstring is slightly adjusted.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

According to a recent [forum post](https://forum.generic-mapping-tools.org/t/changing-symbol-outline-color-using-plot/2410), here's an update for the text symbol gallery example. Since it is not fully clear from the current example how to change the outline color of the symbols, for the last symbol now the outline color is changed.
@michaelgrund michaelgrund added the documentation Improvements or additions to documentation label Dec 6, 2021
@michaelgrund michaelgrund added this to the 0.6.0 milestone Dec 6, 2021
@michaelgrund michaelgrund added the maintenance Boring but important stuff for the core devs label Dec 6, 2021
Copy link
Member

@seisman seisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed maintenance Boring but important stuff for the core devs labels Dec 7, 2021
examples/gallery/symbols/text_symbols.py Outdated Show resolved Hide resolved
examples/gallery/symbols/text_symbols.py Outdated Show resolved Hide resolved
examples/gallery/symbols/text_symbols.py Outdated Show resolved Hide resolved
examples/gallery/symbols/text_symbols.py Outdated Show resolved Hide resolved
examples/gallery/symbols/text_symbols.py Outdated Show resolved Hide resolved
Co-authored-by: Will Schlitzer <schlitzer90@gmail.com>
Copy link
Contributor

@willschlitzer willschlitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Dec 10, 2021
@seisman seisman merged commit 42eb16e into main Dec 10, 2021
@seisman seisman deleted the gallery-upd-textsym branch December 10, 2021 06:41
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Co-authored-by: Will Schlitzer <schlitzer90@gmail.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants