Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update deprecated -JG syntax #1659

Merged
merged 8 commits into from
Dec 15, 2021
Merged

Update deprecated -JG syntax #1659

merged 8 commits into from
Dec 15, 2021

Conversation

michaelgrund
Copy link
Member

@michaelgrund michaelgrund commented Dec 14, 2021

Description of proposed changes

This PR updates the deprecated -JG syntax to account for GMT 6.3 change made at GenericMappingTools/gmt#5780.

Preview at https://pygmt-git-update-depr-jg-gmt.vercel.app/projections/azim/azim_general_perspective.html

Part of #1644

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@michaelgrund michaelgrund added the maintenance Boring but important stuff for the core devs label Dec 14, 2021
@michaelgrund michaelgrund added this to the 0.6.0 milestone Dec 14, 2021
@michaelgrund michaelgrund marked this pull request as draft December 14, 2021 08:23
@michaelgrund michaelgrund mentioned this pull request Dec 14, 2021
31 tasks
Copy link
Member

@weiji14 weiji14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks alright to me. The new syntax does look nicer, will save people from counting all the slashes to figure out which number is changing what parameter!

@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Dec 15, 2021
@michaelgrund michaelgrund marked this pull request as ready for review December 15, 2021 06:36
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Dec 15, 2021
@seisman seisman merged commit 8a6ee2e into main Dec 15, 2021
@seisman seisman deleted the update-depr-jg branch December 15, 2021 07:06
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants