Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a sample dataset notre_dame_topography #1920

Merged
merged 8 commits into from
May 30, 2022
Merged

Conversation

willschlitzer
Copy link
Contributor

This adds @table_5_11.txt to load_sample_data().

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added the enhancement Improving an existing feature label May 7, 2022
@willschlitzer willschlitzer added this to the 0.7.0 milestone May 7, 2022
@willschlitzer willschlitzer self-assigned this May 7, 2022
@@ -30,6 +30,7 @@ def list_sample_data():
"mars_shape": "Table of topographic signature of the hemispheric dichotomy of "
" Mars from Smith and Zuber (1996)",
"ocean_ridge_points": "Table of ocean ridge points for the entire world",
"table511": "Table 5.11 in Davis: Statistics and Data Analysis in Geology.",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think table511 is a good name for this dataset, but I have no idea about the content of the dataset.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The main reason I went with table511 is because that is in line with the GMT remote dataset name. I also have no idea what the content is.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@PaulWessel Could you please explain what the Table_5_11.txt file has?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yikes. My book is sitting on a shelf in Hawaii. I could answer in 12 days when I am back for a few weeks. But vague memory is that is it topography.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dataset is used in ex12 (https://docs.generic-mapping-tools.org/latest/gallery/ex12.html).

Our next example operates on a data set of topographic readings non-uniformly distributed in the plane (Table 5.11 in Davis: Statistics and Data Analysis in Geology, J. Wiley).

According to the example description, perhaps we can name the dataset as "unevenly_sampled_topography"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given John Davis worked for the Kansas Geological Survey I am guessing it is either in Kansas or this is Notre Dame University area in Indiana.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would notre_dame_topgraphy work?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would notre_dame_topgraphy work?

Sounds a good name to me.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably meant notre_dame_topography ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! The dangers of getting on my computer pre-coffee.

pygmt/datasets/samples.py Outdated Show resolved Hide resolved
pygmt/datasets/samples.py Outdated Show resolved Hide resolved
pygmt/datasets/samples.py Outdated Show resolved Hide resolved
pygmt/tests/test_datasets_samples.py Outdated Show resolved Hide resolved
pygmt/tests/test_datasets_samples.py Outdated Show resolved Hide resolved
willschlitzer and others added 2 commits May 28, 2022 08:37
@seisman
Copy link
Member

seisman commented May 28, 2022

/format

pygmt/datasets/samples.py Outdated Show resolved Hide resolved
pygmt/datasets/samples.py Outdated Show resolved Hide resolved
pygmt/datasets/samples.py Outdated Show resolved Hide resolved
pygmt/tests/test_datasets_samples.py Outdated Show resolved Hide resolved
willschlitzer and others added 2 commits May 29, 2022 09:59
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label May 29, 2022
@seisman seisman changed the title Add Table_5_11.txt dataset Add a new sample dataset notre_dame_topography May 29, 2022
@seisman seisman changed the title Add a new sample dataset notre_dame_topography Add a sample dataset notre_dame_topography May 30, 2022
@seisman seisman merged commit 32ca712 into main May 30, 2022
@seisman seisman deleted the add-dataset/table511 branch May 30, 2022 05:25
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label May 30, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants