Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run GMT Dev Tests on Monday, Wednesday and Friday only #1922

Merged
merged 2 commits into from
May 11, 2022
Merged

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented May 10, 2022

Description of proposed changes

Updating the cron tab to run GMT Dev Tests on Monday/Wednesday/Friday instead of daily. A bit annoying to have the tests failing everyday, especially during the weekend. See also #1833 (comment) about having less frequent tests.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@weiji14 weiji14 added the maintenance Boring but important stuff for the core devs label May 10, 2022
@weiji14 weiji14 added this to the 0.7.0 milestone May 10, 2022
@weiji14 weiji14 self-assigned this May 10, 2022
@weiji14 weiji14 marked this pull request as ready for review May 10, 2022 14:40
@weiji14
Copy link
Member Author

weiji14 commented May 10, 2022

FYI, macOS tests breaking due to blosc (which gdal depends on) no longer packaging ZSTD, see #1923

pygmt.exceptions.GMTCLibNotFoundError: Error loading GMT shared library at '/Users/runner/miniconda3/envs/pygmt/lib/libgmt.dylib'.
dlopen(/Users/runner/miniconda3/envs/pygmt/lib/libgmt.dylib, 6): Symbol not found: _ZSTD_compressBound
  Referenced from: /Users/runner/miniconda3/envs/pygmt/lib/libgdal.30.dylib
  Expected in: /Users/runner/miniconda3/envs/pygmt/lib/libblosc.1.dylib
 in /Users/runner/miniconda3/envs/pygmt/lib/libgdal.30.dylib
Error loading GMT shared library at 'libgmt.dylib'.
dlopen(libgmt.dylib, 6): Symbol not found: _ZSTD_compressBound
  Referenced from: /Users/runner/miniconda3/envs/pygmt/lib/libgdal.30.dylib
  Expected in: /Users/runner/miniconda3/envs/pygmt/lib/libblosc.1.dylib
 in /Users/runner/miniconda3/envs/pygmt/lib/libgdal.30.dylib

@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label May 10, 2022
@weiji14 weiji14 merged commit 5daf419 into main May 11, 2022
@weiji14 weiji14 deleted the ci/mon-wed-fri branch May 11, 2022 11:06
@weiji14 weiji14 removed the final review call This PR requires final review and approval from a second reviewer label May 11, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…gTools#1922)

* Schedule GMT Dev Tests on Monday, Wednesday and Friday only
* Update doc/maintenance.md to mention Mon/Wed/Fri cron schedule
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants