Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

load_earth_relief() now returns gridline-registrated grids by default in GMT 6.4 #2052

Merged
merged 6 commits into from
Aug 16, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Aug 12, 2022

Description of proposed changes

See #1929 for context.

Fixes #1929.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the maintenance Boring but important stuff for the core devs label Aug 12, 2022
@seisman seisman added this to the 0.8.0 milestone Aug 12, 2022
@maxrjones
Copy link
Member

The docs are periodically failing with timeouts due to this change (e.g., https://github.com/GenericMappingTools/pygmt/runs/7813705141?check_suite_focus=true). We could prevent this by adding "@earth_relief_10m_g" to

def download_test_data():
.

@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Aug 15, 2022
@seisman seisman force-pushed the fix-load_earth_relief-tests branch from 170c137 to 47e204a Compare August 15, 2022 03:21
@seisman seisman changed the title pygmt.datasets.load_earth_relief() now returns gridline-registrated grids by default in GMT 6.4 load_earth_relief() now returns gridline-registrated grids by default in GMT 6.4 Aug 16, 2022
@seisman seisman merged commit ca68016 into main Aug 16, 2022
@seisman seisman deleted the fix-load_earth_relief-tests branch August 16, 2022 07:00
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Aug 16, 2022
@seisman seisman mentioned this pull request Aug 16, 2022
8 tasks
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
… in GMT 6.4 (GenericMappingTools#2052)

* pygmt.datasets.load_earth_relief() now returns gridline-registrated grids by default in GMT 6.4
* Add a note for GMT 6.3
@yvonnefroehlich yvonnefroehlich mentioned this pull request Dec 21, 2022
65 tasks
@weiji14 weiji14 added the skip-changelog Skip adding Pull Request to changelog label Dec 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

load_earth_relief now returns grid-registrated grids when registration is not specified
4 participants