Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure.savefig: Raise a FileNotFoundError if the parent directory doesn't exist #2160

Merged
merged 4 commits into from
Oct 29, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Oct 14, 2022

Description of proposed changes

Fixes #2092.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman added the enhancement Improving an existing feature label Oct 14, 2022
@seisman seisman added this to the 0.8.0 milestone Oct 14, 2022
pygmt/figure.py Outdated Show resolved Hide resolved
@seisman seisman marked this pull request as draft October 22, 2022 03:16
@seisman seisman marked this pull request as ready for review October 28, 2022 06:27
@seisman seisman added the needs review This PR has higher priority and needs review. label Oct 28, 2022
@weiji14 weiji14 added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Oct 28, 2022
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Oct 29, 2022
@seisman seisman merged commit 1134a40 into main Oct 29, 2022
@seisman seisman deleted the savefig-check-directory branch October 29, 2022 14:07
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
…sn't exist (GenericMappingTools#2160)

Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Figure.savefig() reports confusing errors when saving image into a non-existent directory
2 participants