Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Figure.rose: Deprecate parameter color to fill (remove in v0.12.0) #2181

Merged
merged 1 commit into from
Nov 10, 2022

Conversation

seisman
Copy link
Member

@seisman seisman commented Nov 5, 2022

Description of proposed changes

Address #1617.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@seisman seisman force-pushed the rose-deprecate-color-to-fill branch from d35c0a1 to 837f141 Compare November 5, 2022 03:51
@seisman seisman added the deprecation Deprecating a feature label Nov 7, 2022
@seisman seisman added this to the 0.8.0 milestone Nov 7, 2022
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed final review call This PR requires final review and approval from a second reviewer labels Nov 9, 2022
@seisman seisman merged commit e4e4c43 into main Nov 10, 2022
@seisman seisman deleted the rose-deprecate-color-to-fill branch November 10, 2022 11:59
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deprecation Deprecating a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants