Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust data checks in datasets sample tests #2223

Merged
merged 3 commits into from
Dec 6, 2022
Merged

Conversation

michaelgrund
Copy link
Member

Description of proposed changes

As proposed in #2211 this PR adjusts the data checks in the datasets sample tests for the min() and max() values in the corresponding tables/dfs.

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@michaelgrund michaelgrund added the maintenance Boring but important stuff for the core devs label Dec 5, 2022
@michaelgrund michaelgrund added this to the 0.8.0 milestone Dec 5, 2022
@seisman seisman added the skip-changelog Skip adding Pull Request to changelog label Dec 5, 2022
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
@seisman seisman added the final review call This PR requires final review and approval from a second reviewer label Dec 5, 2022
Copy link
Contributor

@willschlitzer willschlitzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good change!

@seisman seisman merged commit 46004f5 into main Dec 6, 2022
@seisman seisman deleted the adjust-dataset-tests branch December 6, 2022 03:03
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Dec 6, 2022
sixy6e pushed a commit to sixy6e/pygmt that referenced this pull request Dec 21, 2022
Co-authored-by: Dongdong Tian <seisman.info@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Boring but important stuff for the core devs skip-changelog Skip adding Pull Request to changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants