Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project keywords to the pyproject.toml file #2315

Merged
merged 9 commits into from
Jan 26, 2023
Merged

Add project keywords to the pyproject.toml file #2315

merged 9 commits into from
Jan 26, 2023

Conversation

michaelgrund
Copy link
Member

Description of proposed changes

Addresses #2314 and adds keywords to pyproject.toml file.

Further suggestions are welcome!

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@michaelgrund michaelgrund added the documentation Improvements or additions to documentation label Jan 9, 2023
@michaelgrund michaelgrund added this to the 0.9.0 milestone Jan 9, 2023
pyproject.toml Outdated Show resolved Hide resolved
michaelgrund and others added 2 commits January 10, 2023 09:38
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
pyproject.toml Outdated Show resolved Hide resolved
Co-authored-by: Yvonne Fröhlich <94163266+yvonnefroehlich@users.noreply.github.com>
@willschlitzer
Copy link
Contributor

Should "geology" be on the list of keywords or is that too generic?

@yvonnefroehlich
Copy link
Member

Should "geology" be on the list of keywords or is that too generic?

I am fine with "geology" being on the list of keywords. Fronts (see gallery example Line fronts) and the possibility to use self-created symbols can also be useful for crafting maps in geology. Furthermore, the gallery example for the Ternary diagram is also related to geology.

pyproject.toml Outdated Show resolved Hide resolved
michaelgrund and others added 3 commits January 24, 2023 09:12
Co-authored-by: Wei Ji <23487320+weiji14@users.noreply.github.com>
@weiji14 weiji14 added the final review call This PR requires final review and approval from a second reviewer label Jan 24, 2023
@weiji14 weiji14 merged commit eb3a147 into main Jan 26, 2023
@weiji14 weiji14 deleted the add-keywords branch January 26, 2023 07:41
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Jan 26, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants