Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add inline example for colorbar #2373

Merged
merged 9 commits into from
Mar 23, 2023
Merged

Add inline example for colorbar #2373

merged 9 commits into from
Mar 23, 2023

Conversation

willschlitzer
Copy link
Contributor

Addresses #1957

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If wrapping a new module, open a 'Wrap new GMT module' issue and submit reasonably-sized PRs.
  • If adding new functionality, add an example to docstrings or tutorials.
  • Use underscores (not hyphens) in names of Python files and directories.

Slash Commands

You can write slash commands (/command) in the first line of a comment to perform
specific operations. Supported slash commands are:

  • /format: automatically format and lint the code
  • /test-gmt-dev: run full tests on the latest GMT development version

@willschlitzer willschlitzer added the documentation Improvements or additions to documentation label Feb 17, 2023
@willschlitzer willschlitzer self-assigned this Feb 17, 2023
@seisman seisman added this to the 0.9.0 milestone Feb 18, 2023
@seisman
Copy link
Member

seisman commented Mar 16, 2023

Ping @willschlitzer to see if you have time to finish this PR before the v0.9.0 release.

pygmt/src/colorbar.py Outdated Show resolved Hide resolved
willschlitzer and others added 2 commits March 19, 2023 17:07
pygmt/src/colorbar.py Outdated Show resolved Hide resolved
@seisman seisman added the needs review This PR has higher priority and needs review. label Mar 20, 2023
willschlitzer and others added 2 commits March 20, 2023 10:28
@seisman seisman added final review call This PR requires final review and approval from a second reviewer and removed needs review This PR has higher priority and needs review. labels Mar 20, 2023
@seisman seisman merged commit d03862b into main Mar 23, 2023
@seisman seisman deleted the inline-example/colorbar branch March 23, 2023 02:37
@seisman seisman removed the final review call This PR requires final review and approval from a second reviewer label Mar 23, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants