Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PyPI install instructions and API disclaimer message #421

Merged
merged 4 commits into from
Apr 24, 2020

Conversation

weiji14
Copy link
Member

@weiji14 weiji14 commented Apr 17, 2020

Description of proposed changes

In anticipation of v0.1.0 release, we're recommending users to just pip install pygmt (from PyPI) now instead of installing from Github.

Also warning Windows users that using GMT from conda-forge won't work and suggest workarounds. Plus put a disclaimer that the API (functions and classes) can still change in future releases.

Fixes #

Reminders

  • Run make format and make check to make sure the code follows the style guide.
  • Add tests for new features or tests that would have caught the bug that you're fixing.
  • Add new public functions/methods/classes to doc/api/index.rst.
  • Write detailed docstrings for all functions/methods.
  • If adding new functionality, add an example to docstrings or tutorials.

In anticipation of v0.1.0 release, we're recommending users to just `pip install pygmt` (from PyPI) now instead of installing from Github. Also warning Windows users that using GMT from conda-forge won't work and suggest workarounds.
Tweaking the language of our disclaimer on our main page a bit for v0.1.0. Mention that API is subject to change as per semver, until we reach v1.0.0.
@weiji14 weiji14 mentioned this pull request Apr 17, 2020
10 tasks
@weiji14 weiji14 requested a review from a team April 17, 2020 11:24
@weiji14 weiji14 added this to the 0.1.0 milestone Apr 21, 2020
Copy link
Member

@leouieda leouieda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a very minor suggestion. Otherwise, this looks good to go!

README.rst Show resolved Hide resolved
doc/install.rst Outdated Show resolved Hide resolved
doc/install.rst Show resolved Hide resolved
doc/install.rst Show resolved Hide resolved
Co-Authored-By: Leonardo Uieda <leouieda@gmail.com>
@weiji14 weiji14 merged commit 905264e into master Apr 24, 2020
@weiji14 weiji14 deleted the pypi_install branch April 24, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants