Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the instructions for updating the conda package #448

Merged
merged 4 commits into from
May 22, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/release_checklist.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ git push --tags
- [ ] Commit changes to Github

**3rd party update**:
- [ ] Update conda-forge [pygmt-feedstock](https://github.com/conda-forge/pygmt-feedstock)
- [ ] Update conda-forge [pygmt-feedstock](https://github.com/conda-forge/pygmt-feedstock) [Usually done automatically by conda-forge's bot]

---

Expand Down
13 changes: 7 additions & 6 deletions MAINTENANCE.md
Original file line number Diff line number Diff line change
Expand Up @@ -152,17 +152,18 @@ this new folder.
Grab a zip file from the Github release and upload to Zenodo using the previously
reserved DOI.

### Updating the conda package (Not available yet)
### Updating the conda package

After Travis is done building the tag and all builds pass, we need to update the conda
package.
Unfortunately, this needs to be done manually for now.
When a new version is released on PyPI, conda-forge's bot automatically creates version
updates for the feedstock. In most cases, the maintainers can simply merge that PR.

1. Fork the feedstock repository (https://github.com/conda-forge/pygmt-feedstock) if
If changes are needed to be done manually, you can:
seisman marked this conversation as resolved.
Show resolved Hide resolved

1. Fork the [pygmt feedstock repository](https://github.com/conda-forge/pygmt-feedstock) if
you haven't already. If you have a fork, update it.
2. Update the version number and sha256 hash on `recipe/meta.yaml`. You can get the hash
from the PyPI "Download files" section.
3. Add or remove any new dependencies (most are probably only `run` dependencies).
4. Make a new branch, commit, and push your changes **to your fork**.
seisman marked this conversation as resolved.
Show resolved Hide resolved
5. Create a PR against the original feedstock master.
6. Once the CIs are passing, merge or as a maintainer to do so.
6. Once the CIs are passing, merge the PR or ask a maintainer to do so.
seisman marked this conversation as resolved.
Show resolved Hide resolved