Temporarily expect failures for some grdcontour and grdview tests #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Until GMT 6.1.0 is released and we can update the baseline png images properly, use pytest.mark.xfail to temporarily bypass 13 test failures on grdcontour and grdview.
5 tasks
weiji14
added a commit
that referenced
this pull request
Sep 9, 2020
Removes the expected failures (xfail) pytest marks used as a workaround in #503 to deal with grdview failures. * Refactor test to use new check_figures_equal syntax from #590 * Refactor grdview test to use grdcut instead of load_earth_relief The xarray based slicing isn't as precise as grdcut, so some images were a few pixels off when plotted in 3D. * Rename grid explicitly to xrgrid, and use kwargs to reduce code length * Set a Transverse Mercator projection for zaxis_frame test Otherwise GMT (fig_ref) might plot double-lined x and y axis frame, while PyGMT (fig_test) plots a single-lined frame.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Until GMT 6.1.0 is released and we can update the baseline png images properly, use
pytest.mark.xfailto temporarily bypass 13 test failures ongrdcontourandgrdview. Refer to https://docs.pytest.org/en/stable/skipping.html for pytest documentation on xfail/skipping tests.This should allow us to merge PRs a bit more confidently by re-enabling the "Required" CI tests that were disabled. Note that the tests will fail when run on GMT master (i.e. GMT 6.1.0), and once we set a hard requirement on GMT 6.1.0 or newer, this workaround can be removed.
Partially addresses #451, see also #498
Reminders
make formatandmake checkto make sure the code follows the style guide.doc/api/index.rst.